sijie commented on a change in pull request #531: Issue-530 BP-14 BP-14 Relax
Durability - protocol changes preview
URL: https://github.com/apache/bookkeeper/pull/531#discussion_r142498832
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java
##########
@@ -85,14 +89,17 @@
private LedgerMetadataFormat.DigestType digestType;
private byte[] password;
- private Map<String, byte[]> customMetadata = Maps.newHashMap();
+ private Map<String, byte[]> customMetadata;
public LedgerMetadata(int ensembleSize, int writeQuorumSize, int
ackQuorumSize,
Review comment:
it might be good to consider using builder pattern here. ledger type should
have default value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
