sijie commented on a change in pull request #531: Issue-530 BP-14 BP-14 Relax
Durability - protocol changes preview
URL: https://github.com/apache/bookkeeper/pull/531#discussion_r142499593
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtocol.java
##########
@@ -62,6 +62,16 @@
*/
public static final int MASTER_KEY_LENGTH = 20;
+ /**
Review comment:
are you sure to support ledger type in v2 protocol? if you want to support
it, I would suggest you first make sure v2 and v3 support same semantic first
before introducing ledger type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
