eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r145640557
########## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ########## @@ -73,6 +74,14 @@ message BKPacketHeader { required uint64 txnId = 3; } +/** + * Type of Ledger + */ +enum LedgerType { Review comment: I am changing this to a top level enum but I am hitting this bug on protoc https://github.com/google/protobuf/issues/2054 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services