eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146520352
########## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ########## @@ -83,6 +92,7 @@ message Request { optional ReadLacRequest readLacRequest = 104; optional GetBookieInfoRequest getBookieInfoRequest = 105; optional StartTLSRequest startTLSRequest = 106; + optional SyncRequest syncRequest = 107; Review comment: OK, I will rename Sync with Force, so ForceRequest, FORCE, WriteHandle#force().... I will wait for some time before actually performing the rename, I am preparing other patches and this will be very disruptive @jvrao Are you OK with this new name 'force' instead of 'sync' ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services