sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto 
replication should honor ensemble placement policy
URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146479659
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
 ##########
 @@ -797,6 +763,10 @@ public void openComplete(int newrc, final LedgerHandle 
newlh, Object newctx) {
                     return;
                 }
 
+                if (dryrun) {
+                    System.out.println("Recovered ledger " + lId + " : " + 
(fenceRequired ? "[fence required]" : ""));
 
 Review comment:
   @ivankelly it uses log4j. the dryrun is printing on the console rather than 
using log4j, so the information will not be mixed with other log4j logging. the 
`dryrun` is kind of printing an execution plan. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to