sijie commented on a change in pull request #641: Issue-596 Issue-583: Auto
replication should honor ensemble placement policy
URL: https://github.com/apache/bookkeeper/pull/641#discussion_r146758705
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
##########
@@ -797,6 +763,10 @@ public void openComplete(int newrc, final LedgerHandle
newlh, Object newctx) {
return;
}
+ if (dryrun) {
+ System.out.println("Recovered ledger " + lId + " : " +
(fenceRequired ? "[fence required]" : ""));
Review comment:
`dryrun` is a specified by the caller, it is a contract between the caller
and the implementation. if someone is using BookKeeperAdmin in some service,
they are aware of this behavior since it is a contract provided by the admin.
the behavior is expected and determined when using `stdout`.
but using log4j for tool command results make the behavior is a bit
undefined. because the whole behavior is tied with a log4j.properties file. it
is fine if people using the bk shell, but behavior would become undefined if
people integrates BookKeeperAdmin in their tools. they have to be aware of the
implementation of `dryrun` and customize their log4j properties accordingly.
anyway, I will change this to log4j to move forward here and update bkshell
accordingly in the subsequent change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
