ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146485874
########## File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto ########## @@ -83,6 +92,7 @@ message Request { optional ReadLacRequest readLacRequest = 104; optional GetBookieInfoRequest getBookieInfoRequest = 105; optional StartTLSRequest startTLSRequest = 106; + optional SyncRequest syncRequest = 107; Review comment: ForceRequest? force seems clearer to me. sync is suggesting something more akin to flushing. @sijie @eolivelli ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services