ivankelly commented on a change in pull request #642: BP-14 part 1 - metadata 
and protocol changes
URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146486343
 
 

 ##########
 File path: bookkeeper-server/src/main/proto/BookkeeperProtocol.proto
 ##########
 @@ -62,6 +62,7 @@ enum OperationType {
     READ_LAC = 7;
     GET_BOOKIE_INFO = 8;
     START_TLS = 9;
+    SYNC = 10;
 
 Review comment:
   Hmm, I think that sync() api should be renamed to force(). sync() sounds a 
little weak for this operation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to