eolivelli commented on a change in pull request #642: BP-14 part 1 - metadata and protocol changes URL: https://github.com/apache/bookkeeper/pull/642#discussion_r146520915
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerType.java ########## @@ -0,0 +1,46 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + */ +package org.apache.bookkeeper.client.api; + +/** + * Describes the type of ledger. + * LedgerTypes describes the behaviour of the ledger in respect to durability and provides + * hints to the storage of data on Bookies + * + * @since 4.6 + */ +public enum LedgerType { + /** + * Persistent Durability, using Journal.<br> + * Each entry is persisted to the journal and every writes receives and acknowledgement only with the guarantee that + * it has been persisted durabily to it (data is fsync'd to the disk) + */ + PD_JOURNAL, Review comment: If we rename 'sync' to force, for the LedgerType @sijie @ivankelly what is your idea ? FSYNC_REQUIRED_ON_JOURNAL vs FORCE_REQUIRED_ON_JOURNAL vs AUTOMATIC_FORCE_ON_JOURNAL and FSYNC_DEFERRED_ON_JOURNAL vs FORCE_DEFERRED_ON_JOURNAL vs EXPLICIT_FORCE_ON_JOURNAL and SKIP_JOURNAL (@jvrao) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
