ivankelly commented on a change in pull request #755: Issue 750: support
ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle
URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152520871
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntry.java
##########
@@ -21,12 +21,17 @@
package org.apache.bookkeeper.client.api;
import io.netty.buffer.ByteBuf;
+import java.nio.ByteBuffer;
import org.apache.bookkeeper.common.annotation.InterfaceAudience.Public;
import org.apache.bookkeeper.common.annotation.InterfaceStability.Unstable;
/**
* An entry.
*
+ * <p>The entry implementation might be holding references to byte buffers
under the hood. The users holding the
+ * references to the instances of this class, are responsible for calling
{@link LedgerEntry#close()} to release
+ * resources held by the instances.
Review comment:
held by the entry instances.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
