ivankelly commented on a change in pull request #755: Issue 750: support
ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle
URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152522222
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteHandle.java
##########
@@ -41,7 +41,8 @@
/**
* Add entry asynchronously to an open ledger.
*
- * @param data array of bytes to be written
+ * @param data a bytebuf to be written. The bytebuf's reference count will
be decremented by 1 after the
Review comment:
I think it would be better to restate this, or to also state, that the
append call passes ownership to of the bytebuf to the handle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
