pasha-kuznetsov commented on a change in pull request #868: ISSUE #863: BK client error messages needs to be more descriptive URL: https://github.com/apache/bookkeeper/pull/868#discussion_r157331166
########## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/api/BookKeeperApiTest.java ########## @@ -38,6 +43,9 @@ import org.apache.bookkeeper.client.BKException.BKNoSuchLedgerExistsException; import org.apache.bookkeeper.client.BKException.BKUnauthorizedAccessException; import org.apache.bookkeeper.client.MockBookKeeperTestCase; +import org.apache.bookkeeper.util.LoggerOutput; +import org.apache.log4j.spi.LoggingEvent; Review comment: It's pretty tricky here, as `slf4j` doesn't have appenders, and the test is done via capturing the appended `LoggingEvents`, at the `log4j` level... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
