eolivelli commented on issue #912: Journal: Fix journal write queue so it 
decrements properly.
URL: https://github.com/apache/bookkeeper/pull/912#issuecomment-353541159
 
 
   @sijie I know this is a backport from SF fork. I am ok with this patch.
   
   IMHO this patch needed at least one a +1 from at least two committers before 
merging.
   
   What about adding a test case so that we are sure that we do not fall into 
regressions in the future ?
   Maybe I am missing some piece of the story

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to