eolivelli commented on issue #912: Journal: Fix journal write queue so it decrements properly. URL: https://github.com/apache/bookkeeper/pull/912#issuecomment-353595600 @sijie makes sense to me and I agree. From the diff it seemed to me the this change moved the execution of ForceWriteRequest out of a branch and I was afraid that this can affect how the thread is working. So it seemed to me not just a trivial change like the other ones you recently committed
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
