sijie commented on a change in pull request #925: Issue611: restrict max
ensemble change numbers
URL: https://github.com/apache/bookkeeper/pull/925#discussion_r158922037
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -1564,6 +1567,14 @@ void handleBookieFailure(final Map<Integer,
BookieSocketAddress> failedBookies)
int curNumEnsembleChanges = numEnsembleChanges.incrementAndGet();
+ // when the ensemble changes are too frequent, close handle
+ if (curNumEnsembleChanges > maxNumEnsembleChanges){
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("touch maxNumEnsembleChanges");
Review comment:
Can you provide a more meaningful log statement here? E.g. "Ledger {}
reaches max num ensemble changes {}".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
