sijie commented on issue #923: Issue-922 Fix shade plugin configuration URL: https://github.com/apache/bookkeeper/pull/923#issuecomment-354308065 I am not sure why do you need to remove the classifier. We should provide unshaded jar by default, and if users want to use a shaded jar, he can use a shaded classifier jar. For me the shade doesn't have to enforce by default, we should use classifier. So -1 on removing shaded classifier.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
