sijie commented on issue #923: Issue-922 Fix shade plugin configuration URL: https://github.com/apache/bookkeeper/pull/923#issuecomment-354429665 @eolivelli sorry for late response. was stuck with something else today. only get the chance to look at this for now. I don't like the old approach we are using. We only shipped a jar with shaded protobuf and guava. If a project is using bookkeeper and also protobuf and guava, and it is also going to produce a shaded jar, it is going to shade protobuf and guava again. The same set of dependencies are shaded again and again in the dependency chain. At the mimial, we should provide plain artifact and a shaded artifact. @jiazhai @eolivelli please check #928. I have summarized the approaches there.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
