eolivelli commented on a change in pull request #923: Issue-922 Fix shade
plugin configuration
URL: https://github.com/apache/bookkeeper/pull/923#discussion_r159028170
##########
File path: bookkeeper-server/pom.xml
##########
@@ -202,19 +202,16 @@
</configuration>
<executions>
<execution>
+ <id>create-shaded-jar</id>
<phase>package</phase>
<goals>
<goal>shade</goal>
</goals>
<configuration>
<createDependencyReducedPom>true</createDependencyReducedPom>
-
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
Review comment:
No, but actually we don't need to change the package name for our own module.
The problem is about the dependencies declared in the pom if the shaded
artifact.
It seems that the plugin does not publish the reduced pom but the original
one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
