eolivelli commented on a change in pull request #923: Issue-922 Fix shade
plugin configuration
URL: https://github.com/apache/bookkeeper/pull/923#discussion_r159030396
##########
File path: bookkeeper-server/pom.xml
##########
@@ -202,19 +202,16 @@
</configuration>
<executions>
<execution>
+ <id>create-shaded-jar</id>
<phase>package</phase>
<goals>
<goal>shade</goal>
</goals>
<configuration>
<createDependencyReducedPom>true</createDependencyReducedPom>
-
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
Review comment:
It is the createDependencyReducedPom that it is not working.
Maybe it is a bug in the plugin. Le'ts see @sijie findings.
I think the base jar should be non-shaded but we should also provide the jar
without original Guava and Protobuf. These jar are evil in the Hadoop ecosystem
look for "Hbase guava" or "hadoop guava", similar is protobuf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
