sijie commented on issue #930: [WIP] Issue #903: Bc tests based on docker URL: https://github.com/apache/bookkeeper/pull/930#issuecomment-354891069 the overall framework looks good to me. However I am not sure if using a backward compat proxy is the right approach here. 1) I guess the reason it exists is because you want to simplify writing test cases and be able to adopt to multiple versions. But this approach only works for very basic bc tests, because you can't really have a common proxy over multiple versions. 2) I am afraid adding a bc proxy will introduce pains on maintaining the proxy for bc tests. It doesn't sound actually reduce the maintenance overhead here. 3) I would prefer testing BC between client and bookies without extra proxy if possible. You can actually test and assert on the client behaviors that actually talks to bookies and zookeeper, instead of proxying or delegation. Other comments: - I think we need to stop support versions prior to 4.3.0. We need to enforce EOL as we planned in https://cwiki.apache.org/confluence/display/BOOKKEEPER/BP-13+-+Time+Based+Release+Plan - I am not sure whether arquillian is good or not. but the original idea is using arquillian is not only for BC tests, but also for integration/failure injection tests. It is good for use one framework, rather than inventing our own testing wheel for different purposes.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
