sijie commented on issue #930: [WIP] Issue #903: Bc tests based on docker
URL: https://github.com/apache/bookkeeper/pull/930#issuecomment-355204989
 
 
   the maven resolver + groovy approach looks good to me. +1
   
   one comment: regarding docker image - we publish official docker images 
since 4.5.0. it would be good to use the official docker image. so this would 
also cover testing docker images as well.
   
   @eolivelli I would prefer using docker if possible. docker image is pretty 
much a standard container now. 1) using docker images provide better isolation, 
which can increase testing parallelism. 2) we can also test docker images as 
well. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to