sijie commented on issue #888: Rework of binary distribution licenses URL: https://github.com/apache/bookkeeper/pull/888#issuecomment-355805111 @ivankelly after following up the discussions in legal thread, I have a few comments in this PR: 1) I think the NOTICE file should be simplified, as this would impact the downstream projects. And my feeling is most of the content should go to LICENSE file. Because none of them are really relevant (we don't really use them) or copyrights should go to LICENSE file as the general rule. Justin Clean also pointed out Hadoop's NOTICE file contains far too much information. - "If an ALv2 dependency supplies a NOTICE file, its contents must be analyzed and the relevant portions bubbled up into the top-level NOTICE file." [[1]](http://www.apache.org/dev/licensing-howto.html#alv2-dep) - from Justin Clean: Generally NOTICE doesn?t contain copyrights as they are part of the license text and should go in (or be pointed at) by LICENSE. Attributions also do not belong in a NOTICE file and also go in LICENSE. Only relocated headers [4], contents of upstream ALv2 NOTICE files [5], and required 3rd party notices that don?t belong in license [6] need to be in NOTICE. 2) if the LICENSE and NOTICE file can not be generated automatically and still need reviews and eyes, I would suggest removing removing versions from the jars. This increases inconvenience for contributors who sends PRs to bump the version. We should make things easier for contributors. 3) line 205-305 in `LICENSE-all.bin.txt` isn't really needed. - "Assuming once again that that the bundled dependency itself contains no bundled subcomponents under other licenses and thus the ALv2 applies uniformly to all files, there is no need to modify LICENSE" - from Justin MClean: All bundle software licenses needs to be added to LICENSE [1] you can include ALv2 license software if you want. We just need to include 1) licenses that are none ALv2 2) licenses are listed in NOTICE file carried from ALv2 dependencies. 4) please move deps to all module or rename it to `deps/all/` rather than in the root module. because server module has different deps than all module. it is confusing and unclear deps is used by what module. and we should not include licenses that we don't bundle.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
