sijie commented on issue #888: Rework of binary distribution licenses URL: https://github.com/apache/bookkeeper/pull/888#issuecomment-356579707 @ivankelly regarding NOTICE: my comment is about removing the content below circe, because all of them are covered by LICENSE. see Justin's comment: > do we need to include Webbit license (since it is BSD) in Hadoop's distribution? or we don't have to include Webbit license, since it is bundled in Netty and mentioned in Netty's notice file. > (Justin Mclean)Yep you need to include anything that is bundled. [1] If any of the course code from Webbit ends up in a release then yes the BSD license should be added to the release?s LICENSE file. [2] There is no need to have it mentioned in NOTICE as Hadoop have done. [3] I don't think you should remove `circe` from the notice. because it is a relocated copyright, which should appear in NOTICE, according to https://www.apache.org/legal/src-headers.html#headers
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
