kishorekasi commented on a change in pull request #965: BOOKKEEPER-933: Add support for PEM Key file formats URL: https://github.com/apache/bookkeeper/pull/965#discussion_r161113703
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java ########## @@ -1414,118 +1414,137 @@ public String getClientRole() { } /** - * Get the keystore type for client. Default is JKS. + * Get the keyfile type for client. Default is JKS. * * @return */ - public String getTLSKeyStoreType() { - return getString(TLS_KEYSTORE_TYPE, "JKS"); + public String getTLSKeyFileType() { Review comment: will revert to old names ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services