kishorekasi commented on a change in pull request #965: BOOKKEEPER-933: Add
support for PEM Key file formats
URL: https://github.com/apache/bookkeeper/pull/965#discussion_r162149055
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java
##########
@@ -145,14 +145,6 @@
// Client auth provider factory class name. It must be configured on
Bookies to for the Auditor
protected static final String CLIENT_AUTH_PROVIDER_FACTORY_CLASS =
"clientAuthProviderFactoryClass";
- // Client TLS
- protected static final String TLS_KEYSTORE_TYPE = "clientKeyStoreType";
Review comment:
I am moving TLS_XYZ from ServerConfiguration and ClientConfiguration to the
common class AbstractConfiguration and just use one set of config params (no
clientXYZ params anymore). So, effectively this is a dead code. What I am doing
here is to keep just one set of config params so both bookie and client config
params names are same.
AutoRecovery can still use the same set of params as bookies to configure
the bookkeeper client.
Only config param names are changing, but the variable name still remains
the same as TLS_XYZ. Do you still think its a BC issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
