jiazhai commented on a change in pull request #1012: [Merge Yahoo repo]
CMS-1437: use BookieSocketAddress in DNSToSwitchMapping
URL: https://github.com/apache/bookkeeper/pull/1012#discussion_r162830604
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/net/NetUtils.java
##########
@@ -68,18 +66,13 @@ public static String normalizeHostName(String name) {
return hostNames;
}
- public static String resolveNetworkLocation(DNSToSwitchMapping
dnsResolver, InetSocketAddress addr) {
- List<String> names = new ArrayList<String>(1);
-
- if (dnsResolver.useHostName()) {
Review comment:
Thanks, this is following the original change.
Since BookieSocketAddress contains the hostname and InetSocketAddress, Do we
still need this logic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
