jiazhai commented on a change in pull request #1012: [Merge Yahoo repo] 
CMS-1437: use BookieSocketAddress in DNSToSwitchMapping
URL: https://github.com/apache/bookkeeper/pull/1012#discussion_r162833592
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/net/NetUtils.java
 ##########
 @@ -68,18 +66,13 @@ public static String normalizeHostName(String name) {
         return hostNames;
     }
 
-    public static String resolveNetworkLocation(DNSToSwitchMapping 
dnsResolver, InetSocketAddress addr) {
-        List<String> names = new ArrayList<String>(1);
-
-        if (dnsResolver.useHostName()) {
 
 Review comment:
   OK. Thanks. I see. it is still BC issue. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to