sijie commented on a change in pull request #1029: Test compatibility between old hierarchical ledger manager and current URL: https://github.com/apache/bookkeeper/pull/1029#discussion_r162943584
########## File path: tests/backward-compat-hierarchical-ledger-manager/pom.xml ########## @@ -0,0 +1,36 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation=" + http://maven.apache.org/POM/4.0.0 + http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.bookkeeper.tests</groupId> + <artifactId>integration-tests-base-groovy</artifactId> + <version>4.7.0-SNAPSHOT</version> + <relativePath>../integration-tests-base-groovy</relativePath> + </parent> + + <groupId>org.apache.bookkeeper.tests</groupId> + <artifactId>backward-compat-hierarchical-ledger-manager</artifactId> Review comment: it seems that we are going to quickly have many modules under tests. I think it would be better to organize them in a hierarchical way, e.g. put all bc tests under a directory "tests/backward-compat/", so that we categorize similar tests in categorizes, then in future it is easy to have different profiles to activate/deactivate certain types of tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
