sijie commented on a change in pull request #1029: Test compatibility between old hierarchical ledger manager and current URL: https://github.com/apache/bookkeeper/pull/1029#discussion_r162952654
########## File path: tests/backward-compat-hierarchical-ledger-manager/src/test/groovy/org/apache/bookkeeper/tests/TestCompatHierarchicalLedgerManager.groovy ########## @@ -0,0 +1,92 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one +* or more contributor license agreements. See the NOTICE file +* distributed with this work for additional information +* regarding copyright ownership. The ASF licenses this file +* to you under the Apache License, Version 2.0 (the +* "License"); you may not use this file except in compliance +* with the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +*/ +package org.apache.bookkeeper.tests Review comment: I am not saying it is a problem. what I am suggesting here is to use a `proper` package name to categorize those tests, rather than using a general tests. yes, we probably never pull those tests into others to pollute the namespace, but that is some sort of better practices to have `package` consideration in mind. > Using the broad namespace makes it easier to pull in utils, without having to declare each one. not sure I am convinced about this. utils are kind of generic enough to be public to used across different namespaces. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
