sijie commented on a change in pull request #1100: Improve decomission test
URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165764523
 
 

 ##########
 File path: 
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java
 ##########
 @@ -44,14 +46,17 @@
 
     public BookieDecommissionTest() {
         super(NUM_OF_BOOKIES, 480);
-        baseConf.setOpenLedgerRereplicationGracePeriod(String.valueOf(30000));
-        setAutoRecoveryEnabled(true);
+        baseConf.setOpenLedgerRereplicationGracePeriod(100);
+        setAutoRecoveryEnabled(false);
 
 Review comment:
   @reddycharan I think you have a wrong understanding on how autorecovery 
works. autorecovery is a completely isolated thing from bookies, it doesn't 
really stick to any bookies. It can be co-run with bookies, or it can be run as 
separate service. that means you can run less or more autorecovery instances 
that bookies.
   
   in your example, if BK1 is killed, autorecovery daemon will detect that and 
choose a bookie to replace BK1 and replicate entries from BK0 and BK2 to the 
newly chosen bookie.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to