sijie commented on a change in pull request #1100: Improve decomission test
URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165764894
 
 

 ##########
 File path: 
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java
 ##########
 @@ -86,7 +91,18 @@ public void testDecommissionBookie() throws Exception {
          * this decommisionBookie should make sure that there are no
          * underreplicated ledgers because of this bookie
          */
-        bkAdmin.decommissionBookie(Bookie.getBookieAddress(killedBookieConf));
+        bkAdmin.decommissionBookie(
+            Bookie.getBookieAddress(killedBookieConf),
+            () -> {
+                Auditor auditor = recoveryProcess.getAuditor();
+                if (null != auditor) {
 
 Review comment:
   > If there is no Auditor, then there is no replication process, right?
   
   If there is no auditor, there is no replication process then the test will 
fail.
   
   The logic here is just to avoid throw NPE (it is a coding style problem). I 
can change it to checkNotNull(auditor) to explicitly throw NPE if you like.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to