ivankelly commented on a change in pull request #1137: Fix test regression due
to change in default ledger manager
URL: https://github.com/apache/bookkeeper/pull/1137#discussion_r167793795
##########
File path:
bookkeeper-benchmark/src/test/java/org/apache/bookkeeper/benchmark/TestBenchmark.java
##########
@@ -38,6 +39,13 @@ public TestBenchmark() {
super(5);
}
+ @Before
+ public void setUp() throws Exception {
+
baseConf.setLedgerManagerFactoryClassName("org.apache.bookkeeper.meta.FlatLedgerManagerFactory");
Review comment:
Because, if you reference the class,
```
[WARNING]
/home/ivan/src/bookkeeper/checkouts/bench-flake/bookkeeper-benchmark/src/test/java/org/apache/bookkeeper/benchmark/TestBenchmark.java:[44,73]
org.apache.bookkeeper.meta.FlatLedgerManagerFactory in
org.apache.bookkeeper.meta has been deprecated
```
FlatLedgerManagerFactory is never going to move. That in itself would be a
BC break.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
