sijie commented on a change in pull request #1121: [Merge Yahoo repo]:
AsyncReadLastEntry should trigger callback with error when ledger is empty
URL: https://github.com/apache/bookkeeper/pull/1121#discussion_r168241554
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadOnlyLedgerHandle.java
##########
@@ -178,4 +180,19 @@ public String toString() {
protected void initializeExplicitLacFlushPolicy() {
explicitLacFlushPolicy =
ExplicitLacFlushPolicy.VOID_EXPLICITLAC_FLUSH_POLICY;
}
+
+ @Override
+ public void asyncReadLastEntry(ReadCallback cb, Object ctx) {
+ asyncReadLastConfirmed(new ReadLastConfirmedCallback() {
+ @Override
+ public void readLastConfirmedComplete(int rc, long lastConfirmed,
Object ctx) {
+ if (lastConfirmed < 0) {
Review comment:
you need check `rc` first. if `rc` is not `OK`, then fail `ReadCallback`.
Otherwise do the logic to read actual entry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
