sijie commented on a change in pull request #1201: ISSUE #570: Entrylog per
ledger
URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r170554834
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SyncThread.java
##########
@@ -119,6 +119,12 @@ public void startCheckpoint(Checkpoint checkpoint) {
});
}
+ void start() {
Review comment:
I don't think `start` is good name here, there is nothing really to `start`
and it confuses `startCheckpoint`. I would suggest renaming it to
`scheduleCheckpointAtFixedRate(long flushIntervalMs)`.
`flushInterval` should be removed from SyncThread, since it is not used
anyway though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
