sijie commented on a change in pull request #1201: ISSUE #570: Entrylog per
ledger
URL: https://github.com/apache/bookkeeper/pull/1201#discussion_r170557703
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
##########
@@ -82,18 +95,19 @@
*/
public class EntryLogger {
private static final Logger LOG =
LoggerFactory.getLogger(EntryLogger.class);
+ private static final Long INVALID_LEDGERID = new Long(-1);
+ // log file suffix
+ private static final String LOG_FILE_SUFFIX = ".log";
- private static class BufferedLogChannel extends BufferedChannel {
+ class BufferedLogChannel extends BufferedChannel {
Review comment:
you change this to inner class, because of line 132. however I am not sure
we should add `isLedgerDirFull` should be part of `BufferedLogChannel`.
`isSomethingFull` should be part of ledger dirs manager, not part of an entry
log channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
