ivankelly commented on a change in pull request #1192: BP-29 (task 3): use
metadata service uri for constructing registration client
URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170569082
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
##########
@@ -1447,6 +1454,7 @@ public void close() throws BKException,
InterruptedException {
eventLoopGroup.shutdownGracefully();
}
this.regClient.close();
Review comment:
regClient is owned by the metadataDriver. metadataDriver#close should be
responsible for cleaning it up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
