ivankelly commented on a change in pull request #1192: BP-29 (task 3): use
metadata service uri for constructing registration client
URL: https://github.com/apache/bookkeeper/pull/1192#discussion_r170874199
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java
##########
@@ -120,23 +125,27 @@ protected void initialize(AbstractConfiguration<?> conf,
Optional<Object> optionalCtx) throws
MetadataException {
this.conf = conf;
- String metadataServiceUriStr;
+ final String metadataServiceUriStr;
Review comment:
what I'm saying is that metadataServiceUriStr isn't needed. It's used on one
other place, and metadataServiceUri could equally be used there directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
