ivankelly commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-368816118 @reddycharan I'm not suggesting to have a ledgerstorage composed of multiple entrylogs. But the it makes no sense to make this modification on InterleavedLedgerStorage. By definition, this change creates a non-interleaved ledger storage. And SortedLedgerStorage and this change should have absolutely nothing to do with each other. Sorting is sorting entries before they flush, so that entries from the same ledger are close to each other. With logger per ledger, this is pointless. The interleaved in ledgerstorage is the entrylogger. What I would suggest is to create a abstract BaseLedgerStorage which holds common code, and derive a LoggerPerLedgerLedgerStorage and InterleavedLedgerStorage from that. The only difference should be the EntryLogger implementation. If garbagecollection needs to change based on the entrylogger implementation, then each should have it's own garbage collection implemention. > I would suggest no holding this for requesting a new ledger storage implementation. In order to make the community move forward with this change, I would suggest taking what Charan has at this moment, and review it based on that. We can consider any better refactoring after that. What is the rush? I've seen this suggestion to just wave through a patch for expedience a couple of times now, and I think it's a terrible practice. It just means we keep accumulating tech debt. I remember wanting to do a refactor once the twitter changes got in. That never happened for a number of reason. Then we discussed a refactor of checkpointing once yahoo changes are in. This patch in itself is 2900 LOC. Unless some takes two whole days to review that, then its not going to get a thorough review before submission. This problem compounds each time the patch is updated. That alone is reason to slow down.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
