ivankelly commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-369566453 @reddycharan The split looks better than what's there, but I still think sub-task4 is unnecessary and sub-task5 is at wrong level. Another option, which could be less work given what you have already, is to duplicate the classes that you are modifying, and making the changes you need there. This way you don't need to touch SortedLedgerStorage, you don't modify code that all other ledger storages use, and the patch should just be whole file additions, and a small modification for enabling users to use the new ledger storage. It would mean code duplication, but it's easier to factor out duplicate code than to disentangle code. Also, the risk of submission would be zero. To be clear, I appreciate that a lot of work has gone into this, but this doesn't trump my other concerns. Also, per ledger ledger storage is something that I'll be very happy to see in-tree. I even did an implementation for benchmarking years ago[1]. Only ever ran on HDD, so performance sucked. [1] https://github.com/ivankelly/bookkeeper/tree/PerFileLedgerStorage
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
