sijie commented on a change in pull request #1218: Support LacPiggyback,
LongPoll and ExplicitLac in db ledger storage
URL: https://github.com/apache/bookkeeper/pull/1218#discussion_r171250963
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java
##########
@@ -74,10 +83,121 @@
*/
public class DbLedgerStorage implements CompactableLedgerStorage {
+ /**
+ * This class borrows the logic from FileInfo.
+ *
+ * <p>This class is used for holding all the transient states for a given
ledger.
+ */
+ private static class TransientLedgerInfo
+ extends Watchable<LastAddConfirmedUpdateNotification>
+ implements AutoCloseable {
+
+ // lac
+ private Long lac = null;
Review comment:
null has a different meaning than INVALID_ENTRY_ID, when it is null, we need
to read the last entry to examine the lac.
even we can work this around to use long, would still prefer keeping this
consistent with the implementation in SortedLedgerStorage, which is safer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
