sijie commented on a change in pull request #1218: Support LacPiggyback,
LongPoll and ExplicitLac in db ledger storage
URL: https://github.com/apache/bookkeeper/pull/1218#discussion_r171252517
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorage.java
##########
@@ -712,23 +874,38 @@ public EntryLogger getEntryLogger() {
@Override
public long getLastAddConfirmed(long ledgerId) throws IOException {
- throw new UnsupportedOperationException();
+ TransientLedgerInfo ledgerInfo =
transientLedgerInfoCache.getIfPresent(ledgerId);
+ Long lac = null != ledgerInfo ? ledgerInfo.getLastAddConfirmed() :
null;
+ if (null == lac) {
+ ByteBuf bb = getEntry(ledgerId, BookieProtocol.LAST_ADD_CONFIRMED);
Review comment:
no. I have kept the cache as simple and the loading will never throw any
exceptions. If I move the getEntry as part of loader, it complicates error
handling in cache loading, which I don't want to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
