ArvinDevel commented on a change in pull request #832: Issue 620: Close the
fileChannels for read when they are idle
URL: https://github.com/apache/bookkeeper/pull/832#discussion_r171477616
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
##########
@@ -703,7 +716,7 @@ void stop() {
* Entry Log File Id
*/
protected boolean removeEntryLog(long entryLogId) {
- removeFromChannelsAndClose(entryLogId);
+ fileChannelBackingCache.removeFromChannelsAndClose(entryLogId);
Review comment:
We can't invalidate it from all the caches eg. logid2ReadChannel as it's a
threadLocal variable. Do you think it's okay to delete the entryLog file
before close the corresponding fileChannel? I'm not sure if the JVM will throw
exception if we do that. If it's fine then we can remove it at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
