ArvinDevel commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r171750928
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ########## @@ -703,7 +716,7 @@ void stop() { * Entry Log File Id */ protected boolean removeEntryLog(long entryLogId) { - removeFromChannelsAndClose(entryLogId); + fileChannelBackingCache.removeFromChannelsAndClose(entryLogId); Review comment: After add a global readChannel concurrent list, we can let invalidating cache to trigger close operation. So is it still a need to keep the removeFromChannelsAndClose()? I guess it's not anymore. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services