sijie commented on a change in pull request #1225: Issue #570: getting rid of
unnecessary synchronization in InterleavedLedgerStorage
URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171941016
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java
##########
@@ -74,7 +76,7 @@
GarbageCollectorThread gcThread;
// this indicates that a write has happened since the last flush
- private volatile boolean somethingWritten = false;
+ private AtomicBoolean somethingWritten = new AtomicBoolean(false);
Review comment:
nit : make it final
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
