reddycharan commented on a change in pull request #1228: Issue #570: Move logic
of unpersistedbytes to bufferedchannel
URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172461503
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java
##########
@@ -110,11 +150,15 @@ public long getFileChannelPosition() {
* @throws IOException if the write or sync operation fails.
*/
public void flush(boolean shouldForceWrite) throws IOException {
+ flush(shouldForceWrite, false);
+ }
+
+ public void flush(boolean shouldForceWrite, boolean forceMetadata) throws
IOException {
synchronized (this) {
Review comment:
> There's no refactor involved here. flush(boolean,boolean) isn't even
called, so if it's removed, you will only have update flush(boolean).
It is not true. I'm planning to use in my next subtask. You can check how
this method is used in my comprehensive PR -
https://github.com/apache/bookkeeper/pull/1201 . We had quite big conversation
regarding why 'forceMetadata' flag is required - (final conclusion of the
conversation) -
http://mail-archives.apache.org/mod_mbox/bookkeeper-dev/201705.mbox/%3CCAO2yDyahWu0ezJmQ66sdOvZBUofQu%3D8CabPDeH5JTRzkMULUCg%40mail.gmail.com%3E
This conversation happened in May2017 for full thread -
http://mail-archives.apache.org/mod_mbox/bookkeeper-dev/201705.mbox/browser
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
