reddycharan commented on a change in pull request #1228: Issue #570: Move logic 
of unpersistedbytes to bufferedchannel
URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172470978
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java
 ##########
 @@ -110,11 +150,15 @@ public long getFileChannelPosition() {
      * @throws IOException if the write or sync operation fails.
      */
     public void flush(boolean shouldForceWrite) throws IOException {
+        flush(shouldForceWrite, false);
+    }
+
+    public void flush(boolean shouldForceWrite, boolean forceMetadata) throws 
IOException {
         synchronized (this) {
 
 Review comment:
   I was not referring to next subtask code for code refactoring. I was trying 
to explain -"flush(boolean,boolean) isn't even called", that it will be used by 
my future task and it cann't be removed.
   
   It is not reasonable to expect people who touch the code intending to add 
new functionality to fix all the shortcomings of the existing code. It is risky 
and burdensome to touch critical path (change signatures) for mere arguable 
code cleanliness. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to