reddycharan commented on a change in pull request #1281: Issue #570:
Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r180006501
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
##########
@@ -116,21 +121,103 @@ public ConcurrentLongLongHashMap getLedgersMap() {
return entryLogMetadata.getLedgersMap();
}
+ public Long getLedgerId() {
+ return ledgerId;
+ }
+
+ public void setLedgerId(Long ledgerId) {
Review comment:
its true that ledgerId is assigned in the case of entrylogperledger and it
wont be changed. But it wouldn't be possible to assign the ledgerId during the
creation of BufferedLogChannel because of preallocation optimization. So there
has to be setter for ledgerIdAssigned in BufferedLogChannel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
