reddycharan commented on a change in pull request #1281: Issue #570:
Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r177236857
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
##########
@@ -264,6 +274,8 @@ public EntryLogger(ServerConfiguration conf,
// but the protocol varies so an exact value is difficult to determine
this.maxSaneEntrySize = conf.getNettyMaxFrameSizeBytes() - 500;
this.ledgerDirsManager = ledgerDirsManager;
+ this.conf = conf;
+ entryLogPerLedgerEnabled = conf.isEntryLogPerLedgerEnabled();
Review comment:
hmm..I considered moving EntryLogManager, EntryLogManagerForSingleEntryLog
and EntryLogManagerForEntryLogPerLedger out off EntryLogger, but I realized
that there is circular dependency. EntryLogger has a EntryLogManager reference,
and for certain functionalities of EntryLogManager, it need to have reference
of EntryLogger to call its methods in EntryLogManager. So I don’t see much
benefits other than just creating new files and new classes (which I'm ok with
if it is must needed).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
