sijie commented on a change in pull request #1375: BP14 - forceLedger bookie
side implementation
URL: https://github.com/apache/bookkeeper/pull/1375#discussion_r185174515
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
##########
@@ -313,7 +313,9 @@ public void run() {
LOG.debug("Acknowledge Ledger: {}, Entry: {}", ledgerId,
entryId);
}
journalCbQueueSize.dec();
-
journalAddEntryStats.registerSuccessfulEvent(MathUtils.elapsedNanos(enqueueTime),
TimeUnit.NANOSECONDS);
+ if (journalAddEntryStats != null) {
Review comment:
when this can be null?
if this can be null, that is a bug. the whole purpose of having
NullStatsLogger is to avoid this null checking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
