sijie commented on a change in pull request #1375: BP14 - forceLedger bookie
side implementation
URL: https://github.com/apache/bookkeeper/pull/1375#discussion_r185174841
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerStorage.java
##########
@@ -103,12 +104,19 @@ void initialize(ServerConfiguration conf,
long addEntry(ByteBuf entry) throws IOException, BookieException;
/**
- * Read an entry from storage.
+ * Read an entry from storage. In case of {@link
BookieProtocol#LAST_ADD_CONFIRMED} we are going to return the
+ * 'last' written entry.
+ *
+ * @throws Bookie.NoEntryException in case of missing entry
+ * @throws IOException in case of internal failure
+ *
+ * @return the entry, never null
*/
- ByteBuf getEntry(long ledgerId, long entryId) throws IOException;
+ ByteBuf getEntry(long ledgerId, long entryId) throws IOException,
Bookie.NoEntryException;
Review comment:
what is the purpose of the changes in this file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
